[lkml]   [2009]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] vfs: make real_lookup do dentry revalidation with i_mutex held
    On Tue, Mar 17, 2009 at 10:03:35AM -0700, Sage Weil wrote:
    > On Tue, 17 Mar 2009, Christoph Hellwig wrote:
    > > Keeping i_mutes over do_revalidate seem fine from a first glance, but
    > > can you please do it without rearranging the whole code?
    > Yeah, but not without an extra goto. Holding i_mutex over revalidate is
    > only half of it... we also want to go ahead with the ->lookup if the
    > revalidate fails (instead of returning -ENOENT). I make the patch easier
    > to read (with a goto), but I assumed we'd want the resulting code to be
    > more clear?

    Well, if you want to re-organize real_lookup make that a separate patch.
    Might actually be worthwile to do so and clean up the other issues
    in there (too long line in the prototype, spaces after the pointer *,
    too. And then have a small patch ontop to implement the mutex and
    going ahead with the lookup.

     \ /
      Last update: 2009-03-19 20:37    [W:0.021 / U:12.480 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site