Messages in this thread Patch in this message | | | Date | Thu, 19 Mar 2009 13:27:28 GMT | From | Jeremy Fitzhardinge <> | Subject | [tip:x86/mm] x86/32: no need to use set_pte_present in set_pte_vaddr |
| |
Commit-ID: b40c757964bbad76ecfa88eda9eb0b4d76dd8b40 Gitweb: http://git.kernel.org/tip/b40c757964bbad76ecfa88eda9eb0b4d76dd8b40 Author: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> AuthorDate: Wed, 18 Mar 2009 13:03:32 -0700 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Thu, 19 Mar 2009 14:04:18 +0100
x86/32: no need to use set_pte_present in set_pte_vaddr
Impact: cleanup, remove last user of set_pte_present
set_pte_vaddr() is only used to install ptes in fixmaps, and should never be used to overwrite a present mapping.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> Cc: Xen-devel <xen-devel@lists.xensource.com> LKML-Reference: <1237406613-2929-1-git-send-email-jeremy@goop.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- arch/x86/mm/pgtable_32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c index f2e477c..46c8834 100644 --- a/arch/x86/mm/pgtable_32.c +++ b/arch/x86/mm/pgtable_32.c @@ -50,7 +50,7 @@ void set_pte_vaddr(unsigned long vaddr, pte_t pteval) } pte = pte_offset_kernel(pmd, vaddr); if (pte_val(pteval)) - set_pte_present(&init_mm, vaddr, pte, pteval); + set_pte_at(&init_mm, vaddr, pte, pteval); else pte_clear(&init_mm, vaddr, pte);
| |