Messages in this thread | | | Date | Thu, 19 Mar 2009 12:04:49 +0100 | From | Michal Simek <> | Subject | Re: Microblaze linux support |
| |
Ingo Molnar wrote: > * Michal Simek <monstr@monstr.eu> wrote: > >> Ingo Molnar wrote: >>> * Michal Simek <monstr@monstr.eu> wrote: >>> >>>> Hi Ingo, >>>>> * Michal Simek <monstr@monstr.eu> wrote: >>>>> >>>>>> WARNING: externs should be avoided in .c files >>>>>> #110: FILE: arch/microblaze/kernel/microblaze_ksyms.c:45: >>>>>> +extern void __umodsi3(void); >>>>>> >>>>>> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable >>>>>> #111: FILE: arch/microblaze/kernel/microblaze_ksyms.c:46: >>>>>> +EXPORT_SYMBOL(__umodsi3); >>>>> externs should be in header files. >>>>> >>>>> The rest indeed looks like false positives. Thanks for addressing >>>>> these things so quickly! >>>> you are welcome - I can quickly test and add all changes to git. >>>> >>>> Is it good style separate extern definition and EXPORT_SYMBOL? >>>> >>>> I have three choices? >>>> 1. keep extern + EXPORT_SYMBOL below - current style >>>> 2. move only extern to header file >>>> 3. move extern and EXPORT_SYMBOL to header. >>>> >>>> What is preferable way? >>> Where are the symbols defined - by gcc's library? >> yes. > > i suspect it's borderline in that case, and your solution is fine. > The other solution would be to stuff the externs into a header and > have a continuous block of exports with a comment that says: > > /* > * GCC library functions: > */ > EXPORT_SYMBOL(...); > EXPORT_SYMBOL(...); > EXPORT_SYMBOL(...);
Ok. I keep it in current style. Everything is one file and there is comment about.
Thanks, Michal
> Ingo
| |