lkml.org 
[lkml]   [2009]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: VIRTIO_BLK_T_SCSI_CMD handling in virtio-blk
Date
Am Wednesday 18 March 2009 10:16:43 schrieb Hannes Reinecke:
> -               end_dequeued_request(vbr->req, uptodate);
> +               if (blk_pc_request(vbr->req)) {
> +                       vbr->req->data_len = vbr->in_hdr.residual;
> +                       bytes = vbr->in_hdr.data_len;
> +                       vbr->req->sense_len = vbr->in_hdr.sense_len;
> +                       vbr->req->errors = vbr->in_hdr.status;
> +               } else


I think we identified a bug in the old patch:
http://kerneltrap.org/mailarchive/linux-kvm/2008/8/29/3127594
http://kerneltrap.org/index.php?q=mailarchive/linux-kvm/2008/8/29/3128124

Is this fixup still valid?

- if (blk_pc_request(vbr->req)) {
+ if (blk_pc_request(vbr->req) && len >= sizeof(vbr->in_hdr)) {

I forgot almost all details about the problem.

Christian
\
 
 \ /
  Last update: 2009-03-18 10:41    [W:2.226 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site