Messages in this thread | | | Subject | Re: [RFC][PATCH 09/11] perf_counter: revamp syscall input ABI | From | Peter Zijlstra <> | Date | Wed, 18 Mar 2009 09:55:47 +0100 |
| |
On Wed, 2009-03-18 at 15:31 +1100, Paul Mackerras wrote: > Peter Zijlstra writes: > > > The hardware/software classification in hw_event->type became a little strained > > due to the addition of tracepoint tracing. > > > > Instead split up the field and provide a type field to explicitly specify the > > counter type, while using the event_id field to specify which event to use. > > It would be nice if you didn't reuse the name 'type' but instead > called the field something different ('class', perhaps?) to force a > compile error on code that needs to be updated. For example, you > missed a spot in arch/powerpc/kernel/perf_counter.c and you need to > add on the patch below. (Thanks for updating powerpc BTW.)
Yeah, thought of that after I did the patch... :-)
Thanks.
| |