lkml.org 
[lkml]   [2009]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] sched: Clean unused fields from struct rq
Hi Greg,

On Wed, Mar 18, 2009 at 05:00:06PM -0400, Gregory Haskins wrote:
> I actually key off the SCHEDSTAT_VERSION (currently 14) at the top of
> kernel/sched_stats.h. Cursory inspection of the existing code and your
> patch says that this should actually be the value that needs updating
> (vs. vSched-Debug). However, note that I am not sure if there are also
> users of sched-debug that need to see that version bump as well in order
> to remain compatible.

Hmm... so, what's the relation between SCHEDSTAT_VERSION and the "Sched Debug"
version I update in my patch? Assuming there is a relation... :-)

I believe that I actually need to update both versioning mechanims but I think
this is something odd -- either there is one mechanism to handle version or a
comment should clarify why there are two.

> If you are really motivated, you can test your patches against my
> schedtop tool to verify sane behavior (for bumping SCHEDSTAT_VERSION to
> 15, I would expect it to gracefully report that it cannot handle this
> version and exit). You can find both source and rpms here:

Sure I will give it a try -- I'll let you know about the result.

Thanks!
--
Luis Henriques


\
 
 \ /
  Last update: 2009-03-18 22:25    [W:0.413 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site