Messages in this thread | | | Date | Wed, 18 Mar 2009 15:10:19 -0400 (EDT) | From | Christoph Lameter <> | Subject | Re: [PATCH 20/35] Use a pre-calculated value for num_online_nodes() |
| |
On Wed, 18 Mar 2009, Mel Gorman wrote:
> On Wed, Mar 18, 2009 at 12:58:02PM -0400, Christoph Lameter wrote: > > On Wed, 18 Mar 2009, Mel Gorman wrote: > > > > > Naming has never been great, but in this case the static value is a > > > direct replacement of num_online_nodes(). I think having a > > > similarly-named-but-still-different name obscures more than it helps. > > > > Creates a weird new name. Please use nr_online_nodes. Its useful elsewhere > > too. > > > > Ok, I'm dropping this patch for the first pass altogether and will deal > with it later.
This is important infrastructure stuff. num_online_nodes is used in a couple of other places where it could be replaced by nr_online_nodes.
7 grufile.c gru_get_config_info 181 if (num_online_nodes() > 1 && 8 grufile.c gru_get_config_info 187 info.nodes = num_online_nodes(); 9 hugetlb.c return_unused_surplus_pages 878 unsigned long remaining_iterations = num_online_nodes(); a hugetlb.c return_unused_surplus_pages 907 remaining_iterations = num_online_nodes(); b page_alloc.c MAX_NODE_LOAD 2115 #define MAX_NODE_LOAD (num_online_nodes()) c page_alloc.c build_zonelists 2324 load = num_online_nodes(); d page_alloc.c build_all_zonelists 2475 num_online_nodes(), e slub.c list_locations 3651 if (num_online_nodes() > 1 && !nodes_empty(l->nodes) && f svc.c svc_pool_map_choose_mode 127 if (num_online_nodes() > 1) {
In other places its avoided because deemed to be too expensive.
| |