Messages in this thread | | | Date | Wed, 18 Mar 2009 02:09:19 -0400 | From | Christoph Hellwig <> | Subject | VIRTIO_BLK_T_SCSI_CMD handling in virtio-blk |
| |
Currently virtio-blk just sends down the payload for packet command requests, setting the VIRTIO_BLK_T_SCSI_CMD flag in the type field and zeroing out the sector field.
But to make any sense of the payload of a packet command we need the scsi command block (request->cmd) which specifies the operation, location and length for this command.
All backends that I checked just fail VIRTIO_BLK_T_SCSI_CMD commands, so AFAICS no harm is done. But should we really keep this broken support in the protocol around? If we do want to support packet commands in the future we should probably just add the command as the first S/G list entry.
Is there an actual protocol spec for virtio-blk somewhere to write these subtilities down? Or an list of implementations to check at least?
| |