lkml.org 
[lkml]   [2009]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateTue, 17 Mar 2009 03:58:52 -0400
FromChristoph Hellwig <>
SubjectRe: [PATCH 2/7] tracing: replace TP<var> with TP_<var>
On Tue, Mar 10, 2009 at 12:57:12AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@redhat.com>
>
> Impact: clean up
>
> The macros TPPROTO, TPARGS, TPFMT, TPRAWFMT, and TPCMD all look a bit
> ugly. This patch adds an underscore to their names.

Honestly I think they still look ugly.

> DECLARE_TRACE(subsys_eventname,
> - TPPROTO(int firstarg, struct task_struct *p),
> - TPARGS(firstarg, p));
> + TP_PROTO(int firstarg, struct task_struct *p),
> + TP_ARGS(firstarg, p));

Compare that to a

DECLARE_TRACE(subsys_eventname,
trace_proto(int firstarg, struct task_struct *p),
trace_args(firstarg, p));

or even when you insist on UPPERCASE:

DECLARE_TRACE(subsys_eventname,
TRACE_PROTO(int firstarg, struct task_struct *p),
TRACE_ARGS(firstarg, p));




\
 
 \ /
  Last update: 2009-03-17 09:01    [from the cache]
©2003-2010