Messages in this thread Patch in this message | | | From | Mark Brown <> | Subject | [PATCH 1/2] regulator: Don't increment use_count for boot_on regulators | Date | Mon, 16 Mar 2009 19:36:33 +0000 |
| |
Don't set use_count for regulators that are enabled at boot since this stops the supply being disabled by well-behaved consumers which do balanced enables and disabled. Any consumers which don't do disables which are not matched by enables are unable to share regulators - shared regulators are the common case so the API should facilitate them.
Consumers that want to disable regulators that are enabled when they start have two options:
- Do a regulator_enable() prior to the disable to bring the use count in sync with the hardware state; this will ensure that if the regulator was enabled by another driver then this consumer will play nicely with it. - Use regulator_force_disable(); this explicitly bypasses any checks done by the core and documents the inability of the driver to share the supply.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- drivers/regulator/core.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 9448875..8588a24 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -814,7 +814,6 @@ static int set_machine_constraints(struct regulator_dev *rdev, rdev->constraints = NULL; goto out; } - rdev->use_count = 1; } print_constraints(rdev); -- 1.6.2
| |