lkml.org 
[lkml]   [2009]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446.
From
Hi Purshotam,

> +
> +
> +/* MMCSD Init clock in Hz in opendain mode */

s/opendain/opendrain

> +
> +static irqreturn_t mmc_davinci_irq(int irq, void *dev_id)
> +{
> +       struct mmc_davinci_host *host = (struct mmc_davinci_host *)dev_id;


Unnecessary casting from void *.

> +
> +       ret = -EBUSY;
> +       mem_size = r->end - r->start + 1;

How about using resource_size(...) ?

> +       mem = request_mem_region(r->start, mem_size, pdev->name);
> +       if (!mem)
> +               goto out;
> +
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("MMC/SD driver for Davinci MMC controller");

Adding MODULE_AUTHOR and MODULE_ALIAS would be great. You can also add
MAINTAINERS entry if you want.

--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-03-16 19:17    [W:0.114 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site