Messages in this thread | | | Date | Mon, 16 Mar 2009 23:44:04 +0530 | Subject | Re: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446. | From | Trilok Soni <> |
| |
Hi Purshotam,
> + > + > +/* MMCSD Init clock in Hz in opendain mode */
s/opendain/opendrain
> + > +static irqreturn_t mmc_davinci_irq(int irq, void *dev_id) > +{ > + struct mmc_davinci_host *host = (struct mmc_davinci_host *)dev_id;
Unnecessary casting from void *.
> + > + ret = -EBUSY; > + mem_size = r->end - r->start + 1;
How about using resource_size(...) ?
> + mem = request_mem_region(r->start, mem_size, pdev->name); > + if (!mem) > + goto out; > + > + > +MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("MMC/SD driver for Davinci MMC controller");
Adding MODULE_AUTHOR and MODULE_ALIAS would be great. You can also add MAINTAINERS entry if you want.
-- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |