Messages in this thread | | | Date | Mon, 16 Mar 2009 09:59:09 +0100 | From | Vojtech Pavlik <> | Subject | Re: [Patch] Fix the possibility of insane return value of hpet_calibrate() against SMI. |
| |
On Mon, Mar 16, 2009 at 11:34:55AM +0900, Yasunori Goto wrote:
> > I've no sense of feel for how long each calibration run would take. > > Would doing it 5 times show up as a significant increase in the boot > > time for those that care about boot time being as quick as possible? > > Hmm. The loop times is trade off against reliable value.... > Though SMI is rare interruption, I don't know how frequent > hypervisor's switch is. > > Each calibration of this has 1 milli second. > Do you think 5 msec is too long? > If yes, how is 3 msec? Is it still too long?
I would suggest to instead repeat until the total cycle count stops decreasing: That way we can avoid a SMI and yet in the best case only run the calibration 2 times.
-- Vojtech Pavlik Director SuSE Labs
| |