Messages in this thread | | | Date | Sun, 15 Mar 2009 22:51:22 -0400 (EDT) | From | Len Brown <> | Subject | Re: [PATCH] thinkpad-acpi: fix module autoloading for older models |
| |
On Sat, 14 Mar 2009, Henrique de Moraes Holschuh wrote:
> On Sat, 14 Mar 2009, Mathieu Chouquet-Stringer wrote: > > On Sat, Mar 14, 2009 at 04:14:19PM +0100, Kay Sievers wrote: > > > On Sat, Mar 14, 2009 at 11:42, Mathieu Chouquet-Stringer > > > <mchouque@free.fr> wrote: > > > > > > > While for older Thinkpads, you do this (for instance): > > > > IBM_BIOS_MODULE_ALIAS("1[0,3,6,8,A-G,I,K,M-P,S,T]"); > > > > > > Aliases are shell-style globs. Any idea what the ',' are doing in a > > > character class? Confused ... > > > > Good point... I guess it's a typo: perhaps the original authors thought > > of it as a brace expansion? Something like 1{0,3,6,...}? > > I bet that's exactly what happened... it was a long time ago, so I don't > recall exactly what I was (not) thinking about when I did it. > > Thanks for noticing this, and the revised patch looks good.
revised patch (with commit log from 1st patch) applied.
thanks, Len Brown, Intel Open Source Technology Center
| |