lkml.org 
[lkml]   [2009]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 13/17] block: move rq->start_time initialization to blk_rq_init()
    Date
    Impact: rq->start_time is valid for all requests

    rq->start_time was initialized in init_request_from_bio() so special
    requests didn't have start_time set. This has been okay as start_time
    has been used only for fs requests; however, there is no indication of
    this actually is the case or not. Set rq->start_time in blk_rq_init()
    and guarantee that all initialized rq's have its start_time set. This
    improves consistency at virtually no cost and future changes will make
    use of the timestamp for !bio requests.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    ---
    block/blk-core.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/block/blk-core.c b/block/blk-core.c
    index b1781dd..7d0ab48 100644
    --- a/block/blk-core.c
    +++ b/block/blk-core.c
    @@ -134,6 +134,7 @@ void blk_rq_init(struct request_queue *q, struct request *rq)
    rq->cmd = rq->__cmd;
    rq->tag = -1;
    rq->ref_count = 1;
    + rq->start_time = jiffies;
    }
    EXPORT_SYMBOL(blk_rq_init);

    @@ -1094,7 +1095,6 @@ void init_request_from_bio(struct request *req, struct bio *bio)
    req->errors = 0;
    req->hard_sector = req->sector = bio->bi_sector;
    req->ioprio = bio_prio(bio);
    - req->start_time = jiffies;
    blk_rq_bio_prep(req->q, req, bio);
    }

    --
    1.6.0.2


    \
     
     \ /
      Last update: 2009-03-16 03:37    [W:0.020 / U:30.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site