| Date | Fri, 13 Mar 2009 18:10:29 -0700 | From | Greg KH <> | Subject | [patch 052/114] proc: fix kflags to uflags copying in /proc/kpageflags |
| |
2.6.28-stable review patch. If anyone has any objections, please let us know.
------------------
From: Wu Fengguang <fengguang.wu@intel.com>
commit ad3bdefe877afb47480418fdb05ecd42842de65e upstream.
Fix kpf_copy_bit(src,dst) to be kpf_copy_bit(dst,src) to match the actual call patterns, e.g. kpf_copy_bit(kflags, KPF_LOCKED, PG_locked).
This misplacement of src/dst only affected reporting of PG_writeback, PG_reclaim and PG_buddy. For others kflags==uflags so not affected.
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- fs/proc/page.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/proc/page.c +++ b/fs/proc/page.c @@ -80,7 +80,7 @@ static const struct file_operations proc #define KPF_RECLAIM 9 #define KPF_BUDDY 10 -#define kpf_copy_bit(flags, srcpos, dstpos) (((flags >> srcpos) & 1) << dstpos) +#define kpf_copy_bit(flags, dstpos, srcpos) (((flags >> srcpos) & 1) << dstpos) static ssize_t kpageflags_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
|