lkml.org 
[lkml]   [2009]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PROBLEM]: potential unaligned memory access in drivers/usb/gadget/rndis.c
From
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Thu, 12 Mar 2009 16:51:37 -0700

> On Wed, 2009-03-11 at 23:51 -0700, Andrew Morton wrote:
>
> > Maybe the below fixed this? afacit it is queued for 2.6.30 in the
> > net-next tree:
> >
> > commit 35c26c2cf6a6a2d1c48add732d8ba002bd90784c
> > Author: Harvey Harrison <harvey.harrison@gmail.com>
> > AuthorDate: Sat Feb 14 22:56:56 2009 -0800
> > Commit: David S. Miller <davem@davemloft.net>
> > CommitDate: Sat Feb 14 22:56:56 2009 -0800
> >
> > rndis: remove private wrapper of __constant_cpu_to_le32
> >
> > Use cpu_to_le32 directly as it handles constant folding now, replace direct
> > uses of __constant_cpu_to_{endian} as well.
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> >
>
> Doubtful, this patch should be a no-op, any alignment problems that existed
> before will still be there.

Agreed, that patch won't do anything wrt. the alignment issue being
reported here.


\
 
 \ /
  Last update: 2009-03-13 21:55    [W:0.238 / U:0.352 seconds]
©2003-2011 Jasper Spaans. Advertise on this site