lkml.org 
[lkml]   [2009]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [update, rev. 6] Re: [PATCH 1/10] PM: Rework handling of interrupts during suspend-resume (rev. 5)
    Date
    On Friday 13 March 2009, Arve Hjønnevåg wrote:
    > On Thu, Mar 12, 2009 at 1:43 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
    > >
    > > +void __disable_irq(struct irq_desc *desc, unsigned int irq, bool suspend)
    > > +{
    > > + if (suspend) {
    > > + if (desc->action && (desc->action->flags & IRQF_TIMER))
    > > + return;
    >
    > Don't you want "(!desc->action || ..." here to avoid enabling unused
    > interrupts on resume?

    Hmm, good idea, thanks.

    Best,
    Rafael
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-03-13 17:57    [W:4.868 / U:1.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site