Messages in this thread | | | Date | Fri, 13 Mar 2009 12:03:57 +0100 | From | Ingo Molnar <> | Subject | Re: [patch 1/5] x86, bts: detect size of DS fields |
| |
Applied your patches to tip:tracing/hw-branch-tracer, thanks Markus!
I did a small cleanup patch - see it in this thread.
One detail i noticed:
static DEFINE_PER_CPU(struct ds_configuration, ds_cfg_array);
That PER_CPU indirection should be removed - it's enough to have system-wide configuration settings. We dont generally support assymetric CPU capabilities in the same system, and the per_cpu indirection here slows the code down and obfuscates it.
Thanks,
Ingo
| |