lkml.org 
[lkml]   [2009]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ftrace: Avoid double-free of dyn_ftrace

* Zhaolei <zhaolei@cn.fujitsu.com> wrote:

> If dyn_ftrace is free before ftrace_release(),
> ftrace_release() will free it again and make
> ftrace_free_records wrong.
>
> Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
> ---
> kernel/trace/ftrace.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index d33d306..26c45aa 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -356,7 +356,8 @@ void ftrace_release(void *start, unsigned long size)
>
> mutex_lock(&ftrace_lock);
> do_for_each_ftrace_rec(pg, rec) {
> - if ((rec->ip >= s) && (rec->ip < e))
> + if ((rec->ip >= s) && (rec->ip < e) &&
> + !(rec->flags & FTRACE_FL_FREE))
> ftrace_free_rec(rec);

Applied to tip:tracing/ftrace, thanks!

I'm wondering, did you trigger this in practice (if yes, how?),
or have you found it via code review?

Ingo


\
 
 \ /
  Last update: 2009-03-13 10:29    [from the cache]
©2003-2011 Jasper Spaans