lkml.org 
[lkml]   [2009]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dmaengine: sh: Add support DMA-Engine driver for DMA of SuperH
Hi, Matt.

Thank you for your review.

Matt Fleming wrote:
> On Thu, Mar 12, 2009 at 03:44:55PM +0900, Nobuhiro Iwamatsu wrote:
>> This supports DMA-Engine driver for DMA of SuperH.
>> This supported all DMA channels, and it was tested in SH7722/SH7780.
>> This can not use with SH DMA API and can control this in Kconfig.
>>
>
> I was working on support for this, but fortunately for me you beat me
> to a finished implementation ;-)
>
> The code looks good to me. Just a few (very very) minor nits.
>
> Reviewed-by: Matt Fleming <matt@console-pimps.org>
>
> [...]
>
>> +/* for dma engine */
>> +/* mode */
>> +#define SHDMA_MIX_IRQ (1 << 1)
>
> The proper multi-line kernel comment style is
>
> /*
> *
> */
>
> though this comment can all fit on one line.
>
OK, I fix it.
>> +
>> +static void dmae_init(struct sh_dmae_chan *sh_chan)
>> +{
>> + u32 chcr = RS_DEFAULT; /* default is DUAL mode */
>> + sh_dmae_writel(sh_chan, chcr, CHCR);
>> +}
>> +
>> +/*
>> + * Reset DMA controler
>
> controler -> controller
>
Oops, thank you.

I fix your check point and resend patch.

Best regards,
Nobuhiro


\
 
 \ /
  Last update: 2009-03-13 02:05    [W:0.081 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site