lkml.org 
[lkml]   [2009]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH, resend] eliminate spurious pointless WARN_ON()s
On Thu, Mar 12, 2009 at 01:21:50PM +0000, Jan Beulich wrote:
> Namely during early boot, the panic() or BUG() paths may end up in
> smp_call_function_*() with just a single online CPU. In that situation
> the warnings generated are not only meaningless, but also result in
> relevant output being cluttered.
I actually have patches that just fix panic/shutdown to never call
smp_call_function(), but use an own vector. It does all kinds of other things
too that are not appropiate in panic, like allocating memory.

My main motivation was for machine checks which currently always
run into WARN_Ons when they panic with interrupts off, but as you
say there are other cases too like early boot.

Will post them later today or tomorrow.

-Andi


\
 
 \ /
  Last update: 2009-03-12 14:31    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site