Messages in this thread |  | | | Date | Wed, 11 Mar 2009 12:08:13 -0700 | | From | Andrew Morton <> | | Subject | Re: [v1 PATCH 3/8] EDAC: AMD8111 driver source file |
| |
On Wed, 11 Mar 2009 11:55:36 -0700 (PDT) Doug Thompson <norsk5@yahoo.com> wrote:
> > --- On Tue, 3/10/09, Andrew Morton <akpm@linux-foundation.org> wrote: > > > From: Andrew Morton <akpm@linux-foundation.org> > > Subject: Re: [v1 PATCH 3/8] EDAC: AMD8111 driver source file > > To: "Harry Ciao" <qingtao.cao@windriver.com> > > Cc: linux-kernel@vger.kernel.org, bluesmoke-devel@lists.sourceforge.net > > Date: Tuesday, March 10, 2009, 2:46 PM > > On Mon,__ 9 Mar 2009 16:08:12 > > +0800 > > Harry Ciao <qingtao.cao@windriver.com> > > wrote: > > <snip> > > > > +static void edac_pci_write_dword(struct pci_dev *dev, > > int reg, u32 val32) > > > +{ > > > +______ int ret; > > > + > > > +______ ret = pci_write_config_dword(dev, > > reg, val32); > > > +______ if (ret > 0) > > > +______ ______ printk(KERN_ERR > > AMD8111_EDAC_MOD_STR > > > +______ ______ > > ______ " PCI Access Write Error at 0x%x\n", > > reg); > > > +} > > > + > > > +static void edac_pci_write_byte(struct pci_dev *dev, > > int reg, u8 val8) > > > +{ > > > +______ int ret; > > > + > > > +______ ret = pci_write_config_byte(dev, > > reg, val8); > > > +______ if (ret > 0) > > > +______ ______ printk(KERN_ERR > > AMD8111_EDAC_MOD_STR > > > +______ ______ > > ______ " PCI Access Write Error at 0x%x\n", > > reg); > > > +} > > > > > > <spends a while trying to work out what the return value > > of > > pci_read_config_dword() means> > > > > <gets frustrated and gives up> > > > > Is it correct that all of these functions treat a +ve > > return value as > > an error? > > Yes, the config APIs do return an error code on an operation error.
OK, but presumably they're negative error codes, so
if (ret > 0) error() isn't right.
<checks>
Harry has turned that into
if (ret != 0) error(); which looks better.
|  |