Messages in this thread | | | Date | Wed, 11 Mar 2009 20:10:12 +0300 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 08/10] ide: move ide_map_sg() call out from ->dma_setup method |
| |
Hello.
Bartlomiej Zolnierkiewicz wrote:
>>>Move ide_map_sg() call from ->dma_setup implementations >>>and ide_destroy_dmatable() one from *_build_dmatable() to >>>ide_dma_prepare().
>>>There should be no functional changes caused by this patch.
>>>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>>[...] >> >>>Index: b/drivers/ide/au1xxx-ide.c >>>=================================================================== >>>--- a/drivers/ide/au1xxx-ide.c >>>+++ b/drivers/ide/au1xxx-ide.c >>>@@ -272,9 +272,7 @@ static int auide_build_dmatable(ide_driv >>> if (count) >>> return 1; >>> >>>- use_pio_instead: >>>- ide_destroy_dmatable(drive); >>>- >>>+use_pio_instead:
>> Could you please get rid of goto and label too, while at it?
> Sorry but since this patch has been already merged
Merged where?!
> it would be too much work/noise for too little gain IMO.
Will you take a reworked patch from me?
MBR, Sergei
| |