lkml.org 
[lkml]   [2009]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 6/7] tracing: convert irq trace points to new macros
    From: Steven Rostedt <srostedt@redhat.com>

    Impact: enhancement

    Converted the two irq trace point macros. The entry macro copies
    the name of the irq handler, thus it is better to simply use the
    TRACE_FORMAT macro which uses the trace_printk.

    The return of the handler does not need to record the name, thus
    the faster C style handler is more approriate.

    Signed-off-by: Steven Rostedt <srostedt@redhat.com>
    ---
    include/trace/irq_event_types.h | 38 ++++++++++++++++++++++++--------------
    1 files changed, 24 insertions(+), 14 deletions(-)

    diff --git a/include/trace/irq_event_types.h b/include/trace/irq_event_types.h
    index 0147d9e..43bcb74 100644
    --- a/include/trace/irq_event_types.h
    +++ b/include/trace/irq_event_types.h
    @@ -8,26 +8,36 @@
    #undef TRACE_SYSTEM
    #define TRACE_SYSTEM irq

    -TRACE_EVENT_FORMAT(irq_handler_entry,
    +/*
    + * Tracepoint for entry of interrupt handler:
    + */
    +TRACE_FORMAT(irq_handler_entry,
    TP_PROTO(int irq, struct irqaction *action),
    TP_ARGS(irq, action),
    - TP_FMT("irq=%d handler=%s", irq, action->name),
    - TRACE_STRUCT(
    - TRACE_FIELD(int, irq, irq)
    - ),
    - TP_RAW_FMT("irq %d")
    + TP_FMT("irq=%d handler=%s", irq, action->name)
    );

    -TRACE_EVENT_FORMAT(irq_handler_exit,
    +/*
    + * Tracepoint for return of an interrupt handler:
    + */
    +TRACE_EVENT(irq_handler_exit,
    +
    TP_PROTO(int irq, struct irqaction *action, int ret),
    +
    TP_ARGS(irq, action, ret),
    - TP_FMT("irq=%d handler=%s return=%s",
    - irq, action->name, ret ? "handled" : "unhandled"),
    - TRACE_STRUCT(
    - TRACE_FIELD(int, irq, irq)
    - TRACE_FIELD(int, ret, ret)
    +
    + TP_STRUCT__entry(
    + __field( int, irq )
    + __field( int, ret )
    ),
    - TP_RAW_FMT("irq %d ret %d")
    - );
    +
    + TP_printk("irq=%d return=%s",
    + __entry->irq, __entry->ret ? "handled" : "unhandled"),
    +
    + TP_fast_assign(
    + __entry->irq = irq;
    + __entry->ret = ret;
    + )
    +);

    #undef TRACE_SYSTEM
    --
    1.6.1.3
    --


    \
     
     \ /
      Last update: 2009-03-10 06:01    [W:0.023 / U:0.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site