Messages in this thread | | | Date | Mon, 9 Feb 2009 09:42:41 -0800 (PST) | From | Davide Libenzi <> | Subject | Re: [patch 2/2] timerfd extend clockid support |
| |
On Mon, 9 Feb 2009, Michael Kerrisk wrote:
> On Mon, Feb 9, 2009 at 12:23 PM, Davide Libenzi <davidel@xmailserver.org> wrote: > > The following patch extends timerfd clockid support to cover the ones > > supported by timer_create(). > > It exports the invalid_clockid() function outside posix-timers.c to allow > > timerfd to properly check input parameters. > > Andrew, this is (eventually) .30 material, and do not take the patch > > until you have Thomas sign off. > > Thomas, timerfd uses core hrtimer functions for its tasks. By extending > > the clockid support, I assume that the clockids other than CLOCK_MONOTONIC > > and CLOCK_REALTIME, behaves the same from a hrtimer caller POV. Right? > > Hi Davide, > > Have you done any testing of this patch? My attempts at testing with > clocks other than REALTIME and MONOTONIC all don't work so far. In > some cases, my test programs causes the system to hang. Try > experimenting with the (not yet well tested) test program below, to > check the behavior with other clocks.
Michael, no I did not test it and I did not have even the time to peek into the core timer code to see if the usage of other timer types in eventfd would create problems. That's why I asked Thomas if they'd behave differently from an hrtimer caller POV. I'll try to take a look by myself today or tomorrow.
- Davide
| |