Messages in this thread | | | Date | Mon, 9 Feb 2009 22:32:43 +0530 | From | Gautham R Shenoy <> | Subject | Re: [PATCH] cpu hotplug: remove unused cpuhotplug_mutex_lock() |
| |
Hi Lai,
On Fri, Feb 06, 2009 at 02:39:17PM +0800, Lai Jiangshan wrote: > > cpuhotplug_mutex_lock() is not used. this patch remove it.
This should have been long gone with get_online_cpus()/put_online_cpus() patch series. My bad, I missed it.
Thanks for the patch. Acked-by: Gautham R Shenoy <ego@in.ibm.com> > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > --- > cpu.h | 16 ---------------- > 1 file changed, 16 deletions(-) > diff --git a/include/linux/cpu.h b/include/linux/cpu.h > index c2747ac..2643d84 100644 > --- a/include/linux/cpu.h > +++ b/include/linux/cpu.h > @@ -23,7 +23,6 @@ > #include <linux/node.h> > #include <linux/compiler.h> > #include <linux/cpumask.h> > -#include <linux/mutex.h> > > struct cpu { > int node_id; /* The node which contains the CPU */ > @@ -103,16 +102,6 @@ extern struct sysdev_class cpu_sysdev_class; > #ifdef CONFIG_HOTPLUG_CPU > /* Stop CPUs going up and down. */ > > -static inline void cpuhotplug_mutex_lock(struct mutex *cpu_hp_mutex) > -{ > - mutex_lock(cpu_hp_mutex); > -} > - > -static inline void cpuhotplug_mutex_unlock(struct mutex *cpu_hp_mutex) > -{ > - mutex_unlock(cpu_hp_mutex); > -} > - > extern void get_online_cpus(void); > extern void put_online_cpus(void); > #define hotcpu_notifier(fn, pri) { \ > @@ -126,11 +115,6 @@ int cpu_down(unsigned int cpu); > > #else /* CONFIG_HOTPLUG_CPU */ > > -static inline void cpuhotplug_mutex_lock(struct mutex *cpu_hp_mutex) > -{ } > -static inline void cpuhotplug_mutex_unlock(struct mutex *cpu_hp_mutex) > -{ } > - > #define get_online_cpus() do { } while (0) > #define put_online_cpus() do { } while (0) > #define hotcpu_notifier(fn, pri) do { (void)(fn); } while (0) >
-- Thanks and Regards gautham
| |