lkml.org 
[lkml]   [2009]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] libata-sff: fix 32-bit PIO regression
    Hugh Dickins wrote:

    >>>Yes, looks nice, and works for me. My only criticism would be,
    >>>minor issue unchanged by your patch, that actually "slop" isn't
    >>>unlikely enough to deserve an "unlikely" - slop of 1 or 3 is
    >>>unlikely, but slop of 2 is quite common.

    >> Common on what types of ATAPI commands? I can hardly believe that they are
    >>common on the block I/O...

    > When I checked (mounting and listing a CD), about 34% of
    > commands had slop 2.

    Hm, that probably involved the raw block reads. I don't remember the raw
    sector length off-hand but it may well be just even, not divisble by 4.

    > But you're right, now I try copying
    > a large file, there's no slop involved in that at all.

    > Hugh

    MBR, Sergei


    \
     
     \ /
      Last update: 2009-02-09 17:45    [W:0.036 / U:89.292 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site