Messages in this thread | | | Date | Mon, 9 Feb 2009 10:22:04 +0000 (GMT) | From | Hugh Dickins <> | Subject | Re: [PATCH] libata-sff: fix 32-bit PIO regression |
| |
On Mon, 9 Feb 2009, Sergei Shtylyov wrote: > Hugh Dickins wrote: > > > Yes, looks nice, and works for me. My only criticism would be, > > minor issue unchanged by your patch, that actually "slop" isn't > > unlikely enough to deserve an "unlikely" - slop of 1 or 3 is > > unlikely, but slop of 2 is quite common. > > Common on what types of ATAPI commands? I can hardly believe that they are > common on the block I/O...
When I checked (mounting and listing a CD), about 34% of commands had slop 2. But you're right, now I try copying a large file, there's no slop involved in that at all.
Hugh
| |