Messages in this thread | | | Date | Mon, 9 Feb 2009 11:27:18 +0100 | From | Jean Delvare <> | Subject | Re: [PATCH] i2c: add missing KERN_* constants to printks |
| |
On Mon, 9 Feb 2009 09:35:37 +0100, Wolfram Sang wrote: > > I mean the (first) printk in the loop, not the last printk in this > > function. So what I am suggesting is: > > > > + printk(KERN_DEBUG); > > for (i = 0; i < i2c->irqlogidx; i++) > > printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]); > > printk("\n"); > > Hmm, I was told (by Jean ;)) that every printk should end with newline, > otherwise it might get interrupted with other output -> mess.
Correct, however the code was already wrong before Frank's patch, and his patch is fixing a different problem. So I don't have any problem with this, this can be fixed in a later patch if anybody cares.
-- Jean Delvare
| |