lkml.org 
[lkml]   [2009]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] i2c: add missing KERN_* constants to printks
On Mon, 9 Feb 2009 09:35:37 +0100, Wolfram Sang wrote:
> > I mean the (first) printk in the loop, not the last printk in this
> > function. So what I am suggesting is:
> >
> > + printk(KERN_DEBUG);
> > for (i = 0; i < i2c->irqlogidx; i++)
> > printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
> > printk("\n");
>
> Hmm, I was told (by Jean ;)) that every printk should end with newline,
> otherwise it might get interrupted with other output -> mess.

Correct, however the code was already wrong before Frank's patch, and
his patch is fixing a different problem. So I don't have any problem
with this, this can be fixed in a later patch if anybody cares.

--
Jean Delvare


\
 
 \ /
  Last update: 2009-02-09 11:29    [W:0.079 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site