Messages in this thread |  | | | Date | Sun, 8 Feb 2009 10:17:07 -0500 (EST) | | From | Steven Rostedt <> | | Subject | Re: [PATCH tip 2/2] tracing: Introduce trace_buffer_{lock_reserve,unlock_commit} |
| |
On Sun, 8 Feb 2009, Frederic Weisbecker wrote: > > > Ok, yes by making the flags per tracer, it will goes well. > Just one thing, the insertion of an event is sometimes a hot path > like with the functions tracer. And such facility adds some unused function calls > and branch checking. > But on such cases, we can use directly the ring buffer functions :-)
Yes, please keep the direct calls to the ring buffer on the function tracer. The function tracer is also special, in that if we have dynamic tracing turned on, we can simply point to a different function that does different things depending on trace settings. Thanks,
-- Steve
|  |