lkml.org 
[lkml]   [2009]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [git pull -tip] headers_check fixes for other architectures
From
Date
On Fri, 2009-02-06 at 18:24 +0100, Sam Ravnborg wrote:
> >
> > Is this safe OR we can make it more safer:
> >
> > Subject: [PATCH] make linux/types.h as assembly safe
> >
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> > ---
> > include/linux/types.h | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/types.h b/include/linux/types.h
> > index 712ca53..c30973a 100644
> > --- a/include/linux/types.h
> > +++ b/include/linux/types.h
> > @@ -1,6 +1,7 @@
> > #ifndef _LINUX_TYPES_H
> > #define _LINUX_TYPES_H
> >
> > +#ifndef __ASSEMBLY__
> > #ifdef __KERNEL__
> >
> > #define DECLARE_BITMAP(name,bits) \
> > @@ -212,5 +213,5 @@ struct ustat {
> > };
> >
> > #endif /* __KERNEL__ */
> > -
> > +#endif /* __ASSEMBLY__ */
> > #endif /* _LINUX_TYPES_H */
>
> This is wrong...
> We should include the assumed assembly safe asm/types.h
> outside the __ASEMBLY__ ifdef.
>

The following changes since commit f6c727813e03ce0f58d73808da8c9a6bc227249e:
Ingo Molnar (1):
Merge branch 'core/header-fixes' of git://git.kernel.org/.../jaswinder/linux-2.6-tip into core/header-fixes

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git core/header-fixes

Jaswinder Singh Rajput (1):
unconditionally include asm/types.h from linux/types.h

include/linux/types.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Complete diff:
diff --git a/include/linux/types.h b/include/linux/types.h
index c30973a..fca82ed 100644
--- a/include/linux/types.h
+++ b/include/linux/types.h
@@ -1,6 +1,8 @@
#ifndef _LINUX_TYPES_H
#define _LINUX_TYPES_H

+#include <asm/types.h>
+
#ifndef __ASSEMBLY__
#ifdef __KERNEL__

@@ -10,7 +12,6 @@
#endif

#include <linux/posix_types.h>
-#include <asm/types.h>

#ifndef __KERNEL_STRICT_NAMES




\
 
 \ /
  Last update: 2009-02-08 06:57    [from the cache]
©2003-2011 Jasper Spaans