lkml.org 
[lkml]   [2009]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] PCI PM: Do not disable and enable bridges during suspend-resume
Date
On Saturday 07 February 2009, Pavel Machek wrote:
> Hi!
>
> > their standard config spaces are restored. Fix this by not attempting
> > to disable bridges during suspend and enable them during resume.
>
> ...
>
> > Index: linux-2.6/drivers/pci/pci-driver.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/pci/pci-driver.c
> > +++ linux-2.6/drivers/pci/pci-driver.c
> > @@ -428,16 +428,18 @@ static int pci_pm_default_resume(struct
> > {
> > pci_fixup_device(pci_fixup_resume, pci_dev);
> >
> > - if (!pci_is_bridge(pci_dev))
> > - pci_enable_wake(pci_dev, PCI_D0, false);
> > + if (pci_is_bridge(pci_dev))
> > + return 0;
> >
> > + pci_enable_wake(pci_dev, PCI_D0, false);
> > return pci_pm_reenable_device(pci_dev);
> > }
>
> Are you sure? This goes from doing reenable_device to not doing it for
> bridges, seemingly contradicting changelog?

Can you explain what you mean, please?

Thanks,
Rafael


\
 
 \ /
  Last update: 2009-02-07 14:51    [W:0.050 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site