lkml.org 
[lkml]   [2009]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCHv2] PCI: add missing KERN_* constants to printks


Frank Seidel wrote:
> From: Frank Seidel <frank@f-seidel.de>
>
> According to kerneljanitors todo list all printk calls (beginning
> a new line) should have an according KERN_* constant.
> Those are the missing pieces here for the pci subsystem.
>
> Signed-off-by: Frank Seidel <frank@f-seidel.de>
> ---
> drivers/pci/hotplug/pciehp.h | 3 ++-
> drivers/pci/hotplug/shpchp.h | 3 ++-
> drivers/pci/intel-iommu.c | 2 +-
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> --- a/drivers/pci/intel-iommu.c
> +++ b/drivers/pci/intel-iommu.c
> @@ -1960,7 +1960,7 @@ static inline void iommu_prepare_isa(voi
> ret = iommu_prepare_identity_map(pdev, 0, 16*1024*1024);
>
> if (ret)
> - printk("IOMMU: Failed to create 0-64M identity map, "
> + printk(KERN_ERR "IOMMU: Failed to create 0-64M identity map, "
> "floppy might not work\n");
>
> }
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -48,7 +48,8 @@ extern struct workqueue_struct *pciehp_w
> #define dbg(format, arg...) \
> do { \
> if (pciehp_debug) \
> - printk("%s: " format, MY_NAME , ## arg); \
> + printk(KERN_DEBUG "%s: " format, MY_NAME , \
> + ## arg); \
> } while (0)
> #define err(format, arg...) \
> printk(KERN_ERR "%s: " format, MY_NAME , ## arg)

Why didn't you retouch the following dev_printk ?

#define ctrl_dbg(ctrl, format, arg...) \
do { \
if (pciehp_debug) \
dev_printk(, &ctrl->pcie->device, \
format, ## arg); \
} while (0)

> --- a/drivers/pci/hotplug/shpchp.h
> +++ b/drivers/pci/hotplug/shpchp.h
> @@ -50,7 +50,8 @@ extern struct workqueue_struct *shpchp_w
> #define dbg(format, arg...) \
> do { \
> if (shpchp_debug) \
> - printk("%s: " format, MY_NAME , ## arg); \
> + printk(KERN_DEBUG "%s: " format, MY_NAME , \
> + ## arg); \
> } while (0)
> #define err(format, arg...) \
> printk(KERN_ERR "%s: " format, MY_NAME , ## arg)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>

--
Best regards,
Taku Izumi



\
 
 \ /
  Last update: 2009-02-06 10:05    [W:0.064 / U:0.472 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site