lkml.org 
[lkml]   [2009]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/16] DMA-API debugging facility v2
From
Date
On Thu, 2009-02-05 at 18:05 -0800, Chris Wright wrote:
> extra tab

Thanks. Your code to hook it up is better than mine too. I'll steal
that.

> Sample output below (2 of ~2500 faults), pages don't appear to be
> mapped:

What machine did you get that on?

Yeah, I saw one of those. If could be a driver bug, of course -- it
could be unmapping a range before it's actually finished with it. But
that's unlikely.

An alternative explanation... The DMA is aborted¹, and the device
interrupts us to tell us about it at the _same_ time that the IOMMU
interrupts us to tell us about the fault. We process the device
interrupt first, unmap that buffer. And then we process the IOMMU
interrupt... and the buffer is already gone from the list.

It might be interesting to make this code also remember and print the
last range that was unmapped, as well as the currently-mapped ranges.

> (interesting hash_fn spread ;-)

Yeah, that's a little suboptimal, isn't it :)

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation

¹ due to the bug we're chasing now. The range _is_ supposed to be mapped.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-02-06 08:59    [W:0.146 / U:24.628 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site