Messages in this thread | | | Date | Sat, 7 Feb 2009 00:37:14 +0100 | From | Johannes Weiner <> | Subject | Re: [PATCH 3/3][RFC] swsusp: shrink file cache first |
| |
On Sat, Feb 07, 2009 at 02:15:21AM +0900, MinChan Kim wrote: > >>> Grr, you are right. > >>> I agree, currently may_swap doesn't control swap out or not. > >>> so I think we should change it correct name ;) > >> > >> Agreed. What do you think about the following patch? > > > > As for me, I can't agree with you. > > There are two kinds of file-mapped pages. > > > > 1. file-mapped and dirty page. > > 2. file-mapped and no-dirty page > > > > Both pages are not swapped. > > File-mapped and dirty page is synced with original file > > File-mapped and no-dirty page is just discarded with viewpoint of reclaim. > > > > So, may_swap is just related to anon-pages > > Thus, I think may_swap is reasonable. > > How about you ? > > Sorry for misunderstood your point. > It would be better to remain more detaily for git log ? > > 'may_swap' applies not only to anon pages but to mapped file pages as > well. 'may_swap' term is sometime used for 'swap', sometime used for > 'sync|discard'. > In case of anon pages, 'may_swap' determines whether pages were swapout or not. > but In case of mapped file pages, it determines whether pages are > synced or discarded. so, 'may_swap' is rather awkward. Rename it to > 'may_unmap' which is the actual meaning. > > If you find wrong word and sentence, Please, fix it. :)
Cool, thanks. I will resend an updated version soon with your changelog text. And on top of the two fixlets of this series which Andrew already picked up.
Hannes
| |