lkml.org 
[lkml]   [2009]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [git pull -tip] headers_check fixes for other architectures

    * Sam Ravnborg <sam@ravnborg.org> wrote:

    > >
    > > Is this safe OR we can make it more safer:
    > >
    > > Subject: [PATCH] make linux/types.h as assembly safe
    > >
    > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
    > > ---
    > > include/linux/types.h | 3 ++-
    > > 1 files changed, 2 insertions(+), 1 deletions(-)
    > >
    > > diff --git a/include/linux/types.h b/include/linux/types.h
    > > index 712ca53..c30973a 100644
    > > --- a/include/linux/types.h
    > > +++ b/include/linux/types.h
    > > @@ -1,6 +1,7 @@
    > > #ifndef _LINUX_TYPES_H
    > > #define _LINUX_TYPES_H
    > >
    > > +#ifndef __ASSEMBLY__
    > > #ifdef __KERNEL__
    > >
    > > #define DECLARE_BITMAP(name,bits) \
    > > @@ -212,5 +213,5 @@ struct ustat {
    > > };
    > >
    > > #endif /* __KERNEL__ */
    > > -
    > > +#endif /* __ASSEMBLY__ */
    > > #endif /* _LINUX_TYPES_H */
    >
    > This is wrong...
    > We should include the assumed assembly safe asm/types.h
    > outside the __ASEMBLY__ ifdef.

    agreed ...

    Ingo


    \
     
     \ /
      Last update: 2009-02-06 18:43    [W:0.047 / U:30.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site