Messages in this thread | | | Date | Fri, 6 Feb 2009 18:24:53 +0100 | From | Sam Ravnborg <> | Subject | Re: [git pull -tip] headers_check fixes for other architectures |
| |
> > Is this safe OR we can make it more safer: > > Subject: [PATCH] make linux/types.h as assembly safe > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > --- > include/linux/types.h | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/include/linux/types.h b/include/linux/types.h > index 712ca53..c30973a 100644 > --- a/include/linux/types.h > +++ b/include/linux/types.h > @@ -1,6 +1,7 @@ > #ifndef _LINUX_TYPES_H > #define _LINUX_TYPES_H > > +#ifndef __ASSEMBLY__ > #ifdef __KERNEL__ > > #define DECLARE_BITMAP(name,bits) \ > @@ -212,5 +213,5 @@ struct ustat { > }; > > #endif /* __KERNEL__ */ > - > +#endif /* __ASSEMBLY__ */ > #endif /* _LINUX_TYPES_H */
This is wrong... We should include the assumed assembly safe asm/types.h outside the __ASEMBLY__ ifdef.
Sam
| |