lkml.org 
[lkml]   [2009]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] softlockup: convert read_lock in hung_task to rcu_read_lock

* Mandeep Singh Baines <msb@google.com> wrote:

> Ingo Molnar (mingo@elte.hu) wrote:
> >
> > I've applied your patch to tip:core/softlockup, thanks Mandeep!
> >
>
> Oops, I put the conversion to rcu_read_lock in a seperate patch. I
> understand now the convention is to use a patch series only when the
> patches can be applied independently.

What you did is in fact the preferred approach: keep independent stuff
independent and make patches as gradual and split-up as possible. (as long
as the interim state is a working kernel too)

> ---
> Since the tasklist is protected by rcu list operations, it is safe
> to convert the read_lock()s to rcu_read_lock().
>
> Suggested-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Mandeep Singh Baines <msb@google.com>
> ---
> kernel/hung_task.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

Applied to tip:core/softlockup, thanks!

Ingo


\
 
 \ /
  Last update: 2009-02-05 19:17    [W:0.069 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site