lkml.org 
[lkml]   [2009]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Detect mmconfig on nVidia MCP55
Date
On Wednesday 04 February 2009 17:04:40 Ingo Molnar wrote:
> 2) Please use vertical spaces when initializing structure fields. Instead
> of the messy looking (and over-long-line generating) construct of:
>
> pci_mmcfg_config[0].address = (extcfg & 0x00007fff) << 25;
> pci_mmcfg_config[0].pci_segment = 0;
> pci_mmcfg_config[0].start_bus_number = 0;
> pci_mmcfg_config[0].end_bus_number = (1 << (8 - ((extcfg >> 28) &
> 3))) - 1; pci_mmcfg_config_num = 1;
>
> You will get something like:
>
> config->address = (extcfg & 0x00007fff) << 25;
> config->pci_segment = 0;
> config->start_bus_number = 0;
> config->end_bus_number = (1 << (8 - ((extcfg >> 28) &
> 3)));
>
> pci_mmcfg_config = config;
> pci_mmcfg_config_num = 1;
>
> Which makes it more structured, more reviewable - and more pleasant to
> look at as well.

Is this in CodingStyle now? Since I have noticed you are pushing for this
quite a lot lately. And only for structure initialisation and not also for
example for variable declarations?

I find it a matter of personal preference whether it is more pleasant to look
at and whether it is more or less readable.

It is also worse from diff/patch point of view since it can happen in the
future that what would be a one line change now becomes multiline.

Regards,

Tvrtko


\
 
 \ /
  Last update: 2009-02-05 18:17    [W:0.150 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site