Messages in this thread | | | Date | Thu, 5 Feb 2009 15:52:26 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH]: Cleanup: Remove gcc format string warnings when compiling with -Wformat-security (was: Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag) |
| |
* Floris Kraak <randakar@gmail.com> wrote:
> --- a/arch/x86/kernel/dumpstack.c > +++ b/arch/x86/kernel/dumpstack.c > @@ -112,7 +112,7 @@ print_context_stack(struct thread_info *tinfo, > static void > print_trace_warning_symbol(void *data, char *msg, unsigned long symbol) > { > - printk(data); > + printk("%s", data); > print_symbol(msg, symbol); > printk("\n");
Arjan, the code above seems to be dead and never called. These methods:
static const struct stacktrace_ops print_trace_ops = { .warning = print_trace_warning, .warning_symbol = print_trace_warning_symbol,
are not used anywhere that i can see. Could you have a look at this please?
Ingo
| |