Messages in this thread | | | Date | Thu, 05 Feb 2009 09:19:28 -0500 | From | jim owens <> | Subject | Re: Warning and BUG with btrfs and corrupted image |
| |
Pavel Machek wrote: >> If you don't want it, don't compile it in. The Kconfig text is very >> clear. > > No, I'd not expect that option to panic systems. That's why I > suggested: > > diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig > index 29228f5..b7ac847 100644 > --- a/fs/xfs/Kconfig > +++ b/fs/xfs/Kconfig > @@ -77,4 +77,7 @@ config XFS_DEBUG > Note that the resulting code will be HUGE and SLOW, and probably > not useful unless you are debugging a particular problem. > > + Turning this option on will result in kernel panicking any time > + it detects on-disk corruption. > + > Say N unless you are an XFS developer, or you play one on TV.
If you really want a better warning it should simply be:
Choosing Y will make XFS panic on survivable events.
I understand you may have a concern that "normal users" will select the debug option by mistake, but I don't think that is realistic. My experience is they will not build custom debug kernels even if you beg them to. They will only use the distro build and a distro should never turn this option on outside their own labs.
Any non-xfs kernel developer who turns this on and gets snake bit will only do it once.
jim
| |