lkml.org 
[lkml]   [2009]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] x86: UV uv_flush_tlb_others WARN_ON
Cliff Wickman wrote:
> From: Cliff Wickman <cpw@sgi.com>
>
> uv_flush_tlb_others() (arch/x86/kernel/tlb_uv.c)
> The "WARN_ON(!in_atomic())" fails if CONFIG_PREEMPT is not enabled.
> And CONFIG_PREEMPT is not enabled by default in the distribution that
> most UV owners will use.
>
> We could #ifdef CONFIG_PREEMPT the warning, but that is not good form.
>
> And there seems to be no suitable fix to in_atomic() when CONFIG_PREMPT
> is not on.
> As you commented, Ingo:
> > and we have no proper primitive to test for atomicity. (mainly
> > because we dont know about atomicity on a non-preempt kernel)
>
> I propose that we drop the WARN_ON.
>
> Diffed against 2.6.29-rc2
>
> Signed-off-by: Cliff Wickman <cpw@sgi.com>

Heh.. I included it in the first two merges but forgot it in the final
round. Applying to tj-percpu.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-02-05 07:01    [W:0.031 / U:1.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site