lkml.org 
[lkml]   [2009]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cgroups: fix lockdep subclasses overflow
Li Zefan wrote:
> I enabled all cgroup subsystems when compiling kernel, and then:
> # mount -t cgroup -o net_cls xxx /mnt
> # mkdir /mnt/0
>
> This showed up immediately:
> BUG: MAX_LOCKDEP_SUBCLASSES too low!
> turning off the locking correctness validator.
>
> It's caused by the cgroup hierarchy lock:
> for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
> struct cgroup_subsys *ss = subsys[i];
> if (ss->root == root)
> mutex_lock_nested(&ss->hierarchy_mutex, i);
> }
>
> Now we have 9 cgroup subsystems, and the above 'i' for net_cls is 9, but

sorry, a typo here: the above 'i' for net_cls is 8.

> MAX_LOCKDEP_SUBCLASSES is 8.
>
> This patch uses different lockdep keys for different subsystems.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---


\
 
 \ /
  Last update: 2009-02-04 10:19    [W:0.026 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site