Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH 4/4] ptrace: fix possible zombie leak on PTRACE_DETACH | Date | Wed, 4 Feb 2009 17:30:42 -0800 (PST) |
| |
ACK on the change, though looks different if you put __ptrace_detach in ptrace.c with the earliar patch, as I suggest. Also, I think this warrants a comment for the release_task call mentioning briefly what it means:
/* * The flag means __ptrace_detach() determined that this child * was a zombie that should have been auto-reaped already. * Don't leak it. */ if (unlikely(dead)) release_task(child);
Thanks, Roland
| |