[lkml]   [2009]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/7] Make section names compatible with -ffunction-sections -fdata-sections
    On Wed, 4 Feb 2009, Rusty Russell wrote:
    > PS. Here's the extra ones I found. Since you only enable sections on x86,
    > it's not critical, but nice to cover them all.

    It looks like you didn’t base your work on the current copy of the patch
    posted to this thread [1]. That copy already includes all but two of your
    changes (arch/s390/kernel/vdso.c and arch/sparc/kernel/init_task.c, in
    which the lines in question were introduced by recent commits), along with
    some others.

    [1] <>

    > --- a/arch/s390/kernel/vdso32/vdso32_wrapper.S
    > +++ b/arch/s390/kernel/vdso32/vdso32_wrapper.S
    > @@ -1,7 +1,7 @@
    > #include <linux/init.h>
    > #include <asm/page.h>
    > - .section ".data.page_aligned"
    > + .section ""
    > .globl vdso32_start, vdso32_end
    > .balign PAGE_SIZE

    This change is wrong; you need to specify
    .section "", "aw"
    like we do in [1], or else the assembler will not set the ALLOC flag on
    that section, leading to a crash at runtime.

    We will send a new copy of the patch that includes your two changes

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-02-05 02:15    [W:0.032 / U:3.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site