Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH 1/4] ptrace: kill __ptrace_detach(), fix ->exit_state check | Date | Wed, 4 Feb 2009 16:56:39 -0800 (PST) |
| |
> Move the code from __ptrace_detach() to its single caller and kill this > helper. > > Also, fix the ->exit_state check, we shouldn't wake up EXIT_DEAD tasks.
Yes, though that is probably impossible anyway. Perhaps in a de_thread race, but probably harmlessly does nothing. Anyway, certainly fine to change the test to match all others of the same ilk.
> Actually, I think task_is_stopped_or_traced() makes more sense, but this > needs another patch.
Agreed. It is one of those nasty cases where the old semantics are "clearly" wrong, but it's very hard not to worry that some obscure combination of circumstances means that some common-enough case actually depends on the "wrong" wakeup.
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
Thanks, Roland
| |