Messages in this thread | | | Subject | Re: [patch 07/41] fbdev/atyfb: Fix DSP config on some PowerMacs & PowerBooks | From | Benjamin Herrenschmidt <> | Date | Thu, 05 Feb 2009 10:51:15 +1100 |
| |
On Wed, 2009-02-04 at 10:46 -0800, Greg KH wrote: > plain text document attachment > (fbdev-atyfb-fix-dsp-config-on-some-powermacs-powerbooks.patch) > 2.6.27-stable review patch. If anyone has any objections, please let us know.
My only possible worry with that one is the first generation clamshell iBook which uses a Mobility M1 chip, for which we haven't had anybody testing whether this would break it or not ...
So if anybody with such a machine is reading this, please holler...
Cheers, Ben.
> ------------------ > > From: Risto Suominen <Risto.Suominen@gmail.com> > > commit 7fbb7cadd062baf299fd8b26a80ea99da0c3fe01 upstream. > > Since the complete re-write in 2.6.10, some PowerMacs (At least PowerMac 5500 > and PowerMac G3 Beige rev A) with ATI Mach64 chip have suffered from unstable > columns in their framebuffer image. This seems to depend on a value (4) read > from PLL_EXT_CNTL register, which leads to incorrect DSP config parameters to > be written to the chip. This patch uses a value calculated by aty_init_pll_ct > instead, as a starting point. > > There are questions as to whether this should be extended to other platforms > or maybe made dependent on specific chip types, but in the meantime, this has > been tested on various powermacs and works for them so let's commit it. > > Signed-off-by: Risto Suominen <Risto.Suominen@gmail.com> > Tested-by: Michael Pettersson <mike@it.uu.se> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > --- > drivers/video/aty/mach64_ct.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > --- a/drivers/video/aty/mach64_ct.c > +++ b/drivers/video/aty/mach64_ct.c > @@ -8,6 +8,9 @@ > #include <asm/io.h> > #include <video/mach64.h> > #include "atyfb.h" > +#ifdef CONFIG_PPC > +#include <asm/machdep.h> > +#endif > > #undef DEBUG > > @@ -536,6 +539,14 @@ static int __devinit aty_init_pll_ct(con > pll->ct.xclk_post_div_real = postdividers[xpost_div]; > pll->ct.mclk_fb_div = q * pll->ct.xclk_post_div_real / 8; > > +#ifdef CONFIG_PPC > + if (machine_is(powermac)) { > + /* Override PLL_EXT_CNTL & 0x07. */ > + pll->ct.xclk_post_div = xpost_div; > + pll->ct.xclk_ref_div = 1; > + } > +#endif > + > #ifdef DEBUG > pllmclk = (1000000 * pll->ct.mclk_fb_mult * pll->ct.mclk_fb_div) / > (par->ref_clk_per * pll->ct.pll_ref_div); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |