Messages in this thread | | | Subject | Re: [PATCH NET-NEXT 01/10] clocksource: allow usage independent of timekeeping.c | From | john stultz <> | Date | Wed, 04 Feb 2009 11:25:42 -0800 |
| |
On Wed, 2009-02-04 at 07:09 -0800, Daniel Walker wrote: > On Wed, 2009-02-04 at 15:46 +0100, Patrick Ohly wrote: > > In an earlier revision of the patch I had adapted clocksource itself so > > that it could be used outside of the time keeping code; John wanted me > > to use these smaller structs instead that you now find in the current > > patch. > > Well, I think your original idea was better.. I don't think we need the > duplication of underlying clocksource mechanics. > > > Eventually John wants to refactor clocksource so that it uses them and > > just adds additional elements in clocksource. Right now clocksource is a > > mixture of different concepts. Breaking out cyclecounter and timecounter > > is a first step towards that cleanup. > > The problem I see is that your putting off the cleanup of struct > clocksource with duplication.. It should go in reverse , you should use > clocksources for your patch set. Which will motivate John to clean up > the clocksource structure.
I strongly disagree. Misusing a established structure for unintended use is just bad. What Patrick wants to use the counters for has very different semantics then how clocksources are used.
I think having a bit of redundancy in two structures is good motivation for me to clean up the clocksources to use cyclecounters.
thanks -john
| |