Messages in this thread Patch in this message |  | | | From | Alberto Bertogli <> | | Subject | [PATCH] Do not __always_inline bvec_kmap_irq() and bvec_kunmap_irq() | | Date | Wed, 4 Feb 2009 16:49:55 -0200 |
| |
On Tue, Feb 03 2009, Andrew Morton wrote: > The comment is wrong - this was a sparc requirement, long since removed.
So remove both the comment and the inline requirement, going back to the inline hint.
Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar> --- This is the same patch as before, except it's properly indented because everything fits < 80 columns or so.
include/linux/bio.h | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index 713ec6e..972a0e4 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -442,11 +442,8 @@ extern struct biovec_slab bvec_slabs[BIOVEC_NR_POOLS] __read_mostly; /* * remember never ever reenable interrupts between a bvec_kmap_irq and * bvec_kunmap_irq! - * - * This function MUST be inlined - it plays with the CPU interrupt flags. */ -static __always_inline char *bvec_kmap_irq(struct bio_vec *bvec, - unsigned long *flags) +static inline char *bvec_kmap_irq(struct bio_vec *bvec, unsigned long *flags) { unsigned long addr; @@ -462,8 +459,7 @@ static __always_inline char *bvec_kmap_irq(struct bio_vec *bvec, return (char *) addr + bvec->bv_offset; } -static __always_inline void bvec_kunmap_irq(char *buffer, - unsigned long *flags) +static inline void bvec_kunmap_irq(char *buffer, unsigned long *flags) { unsigned long ptr = (unsigned long) buffer & PAGE_MASK; -- 1.6.1.1.363.g2a3bd
|  |