lkml.org 
[lkml]   [2009]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] usb-serial : fix the nousb oops
Date
Am Wednesday 04 February 2009 00:58:14 schrieb Greg KH:
> On Mon, Feb 02, 2009 at 09:43:04AM +0800, Dave Young wrote:

> > No, it is not new thing. usb serial drivers normally call
> > usb_serial_register first, then usb_register, usb_register will fail
> > due to "nousb" checking, but usb_serial_register no.
>
> But as usb_register will fail, shouldn't they properly back out and no
> oopses happen? This sounds like a simple fix to the drivers that are
> failing here, not changing the usb-serial core.

usb_register() can also fail for other reasons. There's no way you
can save drivers from needing to cleanly fail in that case.

> And this should only be an issue if you build your drivers into the
> kernel, right?

No, you can load drivers by other methods than udev.

Regards
Oliver


\
 
 \ /
  Last update: 2009-02-04 09:15    [W:0.092 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site