Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH 1/2] usb-serial : fix the nousb oops | Date | Wed, 4 Feb 2009 09:12:39 +0100 |
| |
Am Wednesday 04 February 2009 00:58:14 schrieb Greg KH: > On Mon, Feb 02, 2009 at 09:43:04AM +0800, Dave Young wrote:
> > No, it is not new thing. usb serial drivers normally call > > usb_serial_register first, then usb_register, usb_register will fail > > due to "nousb" checking, but usb_serial_register no. > > But as usb_register will fail, shouldn't they properly back out and no > oopses happen? This sounds like a simple fix to the drivers that are > failing here, not changing the usb-serial core.
usb_register() can also fail for other reasons. There's no way you can save drivers from needing to cleanly fail in that case.
> And this should only be an issue if you build your drivers into the > kernel, right?
No, you can load drivers by other methods than udev.
Regards Oliver
| |